CriteriaBuildAndSort patch

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

CriteriaBuildAndSort patch

Chuck Deal
Would it be possible to break up CriteriaBuildAndSort into two classes?  The main reason is for easier subclassing.  In addition to the refactoring of the superclass, I made a few of the fields protected so that they could be used by subclasses.

Note: I am not set on BaseCriteriaBuildAndSort, I just wanted super class type name so that CriteriaBuildAndSort remained backwards compatible.

Any thoughts?

CriteriaBuildAndSort.java
BaseCriteriaBuildAndSort.java

I am a Windows dev, with limited ability to install new apps, so git might be out of the question for me, sorry about that.  If necessary, I may be able to extract the source.jar and provide diff output.
Reply | Threaded
Open this post in threaded view
|

Re: CriteriaBuildAndSort patch

n8han
Administrator
Hi Chuck. I looked at this when you posted, but I wanted to delay integrating it until 1.3.0 was safely out the door. I've checked it in now. Would you mind writing a little documentation block for BaseCriteriaBuildAndSort?

Nathan
Reply | Threaded
Open this post in threaded view
|

Re: CriteriaBuildAndSort patch

Chuck Deal
Not to "play it dumb", but how much commenting are you looking for?  I added a class level comment based upon the original work.  However, if you are looking to improve the comments overall (on the original class and the new refactored class) then I can take another stab at it.

BaseCriteriaBuildAndSort.java
CriteriaBuildAndSort.java
Reply | Threaded
Open this post in threaded view
|

Re: CriteriaBuildAndSort patch

n8han
Administrator
That's all I was looking for, thanks!

Nathan